Re: [PATCH V2] opkg-build: add detection if using GNU tar.

[Paul Barker <paul@paulbarker.me.uk>]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

On Tue, Jun 03, 2014 at 11:25:35AM +0100, tom@ewsting.org wrote:
> From: Thomas Ingleby <thomas.c.ingleby@intel.com>
> 
> * Some options of GNU tar do not exist on other implementations
> 
> Signed-off-by: Thomas Ingleby <thomas.c.ingleby@intel.com>

I've made a couple of slight further changes, hope you don't mind.

I've changed the subject to:

    opkg-build: Detect if tar supports '--format' option

I've also added a comment before the block of code which sets tarformat:

+# Determine if tar supports the --format argument by checking the help output.
+#
+# This is needed because:
+#    - Busybox tar doesn't support '--format'
+#    - On some Linux distros, tar now defaults to posix format if '--format'
+#      isn't explictly specified
+#    - Opkg doesn't currently support posix format archives
+#
+# It's easier to check for mention of the '--format' option than to detect the
+# tar implementation and maintain a list of which support '--format'.

I've merged this to master with those changes. Sadly I made an error writing the
comment and pushed too soon so I've pushed another commit to fix that.

Many thanks,

-- 
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

[-- Attachment #2: Type: application/pgp-signature, Size: 501 bytes --]