From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1Wson5-0001c5-TI
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 03:42:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1Wsomt-0007UK-Pa
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 03:42:19 -0400
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:45683)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1Wsomt-0007P1-FQ
	for qemu-devel@nongnu.org; Fri, 06 Jun 2014 03:42:07 -0400
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Fri, 6 Jun 2014 08:41:43 +0100
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id BCC281B08072
	for <qemu-devel@nongnu.org>; Fri,  6 Jun 2014 08:41:35 +0100 (BST)
Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com
	[9.149.37.229])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id s567fBSu23527626
	for <qemu-devel@nongnu.org>; Fri, 6 Jun 2014 07:41:11 GMT
Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s567fBiU030436
	for <qemu-devel@nongnu.org>; Fri, 6 Jun 2014 01:41:11 -0600
Date: Fri, 6 Jun 2014 09:41:09 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20140606094109.577477ea.cornelia.huck@de.ibm.com>
In-Reply-To: <1401273557-6578-2-git-send-email-cornelia.huck@de.ibm.com>
References: <1401273557-6578-1-git-send-email-cornelia.huck@de.ibm.com>
	<1401273557-6578-2-git-send-email-cornelia.huck@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: unset interfering
	variables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>

On Wed, 28 May 2014 12:39:17 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> The check for big or little endianness relies on grep reporting
> match/non-match on the generated binary. If the user specified
> --binary-files=without-match in their GREP_OPTIONS, this will fail.
> 
> Let's follow what autoconf does and unset GREP_OPTIONS and CLICOLOR_FORCE
> at the beginning of the script.
> 
> Reported-by: Eugene (jno) Dvurechenski <jno@linux.vnet.ibm.com>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>  configure | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/configure b/configure
> index 0e516f9..525da56 100755
> --- a/configure
> +++ b/configure
> @@ -3,6 +3,11 @@
>  # qemu configure script (c) 2003 Fabrice Bellard
>  #
> 
> +# Unset some variables known to interfere with behavior of common tools,
> +# just as autoconf does.
> +CLICOLOR_FORCE= GREP_OPTIONS=
> +unset CLICOLOR_FORCE GREP_OPTIONS
> +
>  # Temporary directory used for files created while
>  # configure runs. Since it is in the build directory
>  # we can safely blow away any previous version of it

Is there an obvious tree to merge configure changes through, or should
I just throw it into my next s390 pull request?