From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752565AbaFFNXN (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Jun 2014 09:23:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13814 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752128AbaFFNXL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Jun 2014 09:23:11 -0400
Date: Fri, 6 Jun 2014 15:22:47 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Andi Kleen <ak@linux.intel.com>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Stephane Eranian <eranian@google.com>, David Ahern <dsahern@gmail.com>,
        Vince Weaver <vincent.weaver@maine.edu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools: perf: util: parse-events.c: Cleaning up missing
 null-terminate after strncpy call
Message-ID: <20140606132247.GA1110@krava.brq.redhat.com>
References: <1401918378-3842-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
 <20140604222047.GA16855@tassilo.jf.intel.com>
 <CAFo99gY_GZg7TY=H_UZBDL3dP2vL6NW-TCvtCDx+voY0uH80AA@mail.gmail.com>
 <20140604223114.GC16855@tassilo.jf.intel.com>
 <CAFo99gb4+_nn-5PonfgNfXfyB9PdqsiWX=VqgSxRUtP3oOhD9Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFo99gb4+_nn-5PonfgNfXfyB9PdqsiWX=VqgSxRUtP3oOhD9Q@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 06, 2014 at 03:16:56PM +0200, Rickard Strandqvist wrote:
> Hi
> 
> I really do not want to complicate things here, both work course here.
> But sptlcpy is definitely faster. But this is hardly time-critical
> code, so maybe it looks better to use snprintf in both cases.
> 
> I vote for sptlcpy, but who decides?
> Someone decides and I submit another patch :-)

I vote for snprintf ;-)

jirka

> 
> Best regards
> Rickard Strandqvist
> 
> 
> 2014-06-05 0:31 GMT+02:00 Andi Kleen <ak@linux.intel.com>:
> > On Thu, Jun 05, 2014 at 12:23:55AM +0200, Rickard Strandqvist wrote:
> >> Hi
> >>
> >> A little embarrassing, but I actually did not know that there was a
> >> better replacement for strncpy.
> >
> > This works for perf, but not in general because standard glibc
> > does not have strlcpy. snprintf works always.
> >
> > In practice if you could tolerate strncpy always zeroing
> > the complete string before you can also tolerate snprintf.
> >
> > -Andi