From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@primarydata.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org,
trond.myklebust@primarydata.com, hch@infradead.org
Subject: Re: [PATCH v2 1/2] nfsd: Protect addition to the file_hashtbl
Date: Fri, 6 Jun 2014 07:14:31 -0700 [thread overview]
Message-ID: <20140606141431.GC9303@infradead.org> (raw)
In-Reply-To: <1402060026-26511-2-git-send-email-jlayton@primarydata.com>
On Fri, Jun 06, 2014 at 09:07:05AM -0400, Jeff Layton wrote:
> From: Trond Myklebust <trond.myklebust@primarydata.com>
>
> Ensure that we only can have a single struct nfs4_file per inode
> in the file_hashtbl and make addition atomic with respect to lookup.
>
> To prevent an i_lock/state_lock inversion, change nfsd4_init_file to
> use ihold instead if igrab. That's also more efficient anyway as we
> definitely hold a reference to the inode at that point.
>
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
> Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2014-06-06 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 13:07 [PATCH v2 0/2] nfsd: preliminary patches for client_mutex removal Jeff Layton
2014-06-06 13:07 ` [PATCH v2 1/2] nfsd: Protect addition to the file_hashtbl Jeff Layton
2014-06-06 14:14 ` Christoph Hellwig [this message]
2014-06-06 13:07 ` [PATCH v2 2/2] nfsd: avoid taking the state_lock while holding the i_lock Jeff Layton
2014-06-07 14:09 ` Christoph Hellwig
2014-06-07 14:28 ` Jeff Layton
2014-06-07 14:31 ` Christoph Hellwig
2014-06-07 14:34 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606141431.GC9303@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.