All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Moreau <pierre.morrow-GANU6spQydw@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] drm/nouveau: print a message when KMS is disabled
Date: Sat, 7 Jun 2014 21:39:46 +0200	[thread overview]
Message-ID: <20140607193946.GA8015@testlinux> (raw)
In-Reply-To: <1394418209-2244-1-git-send-email-pierre.morrow-GANU6spQydw@public.gmane.org>

Hi,

Any thoughts on this patch?

Pierre Moreau

On 03:23 AM - Mar 10 2014, Pierre Moreau wrote:
> Signed-off-by: Pierre Moreau <pierre.morrow-GANU6spQydw@public.gmane.org>
> ---
> 
> If KMS is disabled, Nouveau will now announce in the logs that it won't load.
> 
> (Adding Nouveau list as recipient.)
> 
>  drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
> index 89c484d..bb6409b 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
> @@ -984,8 +984,10 @@ nouveau_drm_init(void)
>  #endif
>  	}
>  
> -	if (!nouveau_modeset)
> +	if (!nouveau_modeset) {
> +		DRM_INFO("Nouveau will not load as KMS was disabled.\n");
>  		return 0;
> +	}
>  
>  	nouveau_register_dsm_handler();
>  	return drm_pci_init(&driver, &nouveau_drm_pci_driver);
> -- 
> 1.9.0
> 
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau

      parent reply	other threads:[~2014-06-07 19:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  2:23 [PATCH] drm/nouveau: print a message when KMS is disabled Pierre Moreau
     [not found] ` <1394418209-2244-1-git-send-email-pierre.morrow-GANU6spQydw@public.gmane.org>
2014-06-07 19:39   ` Pierre Moreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140607193946.GA8015@testlinux \
    --to=pierre.morrow-ganu6spqydw@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.