Re: [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set

["Michael S. Tsirkin" <mst@redhat.com>]

On Fri, Jun 06, 2014 at 10:26:15PM -0300, Eduardo Habkost wrote:
> It would be much better if we didn't terminate QEMU inside
> device_post_init(), but at least exiting cleanly is better than aborting
> and dumping core.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/core/qdev.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index e65a5aa..74862c2 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -901,7 +901,13 @@ static void device_initfn(Object *obj)
>  
>  static void device_post_init(Object *obj)
>  {
> -    qdev_prop_set_globals(DEVICE(obj), &error_abort);
> +    Error *err = NULL;
> +    qdev_prop_set_globals(DEVICE(obj), &err);
> +    if (err) {
> +        qerror_report_err(err);
> +        error_free(err);
> +        exit(EXIT_FAILURE);
> +    }
>  }
>  
>  /* Unlink device from bus and free the structure.  */
> -- 
> 1.9.0