All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lsof: fix "'TCP_*' undeclared" build errors
Date: Mon, 9 Jun 2014 15:20:00 +0200	[thread overview]
Message-ID: <20140609152000.40043f97@free-electrons.com> (raw)
In-Reply-To: <1399042764-22388-2-git-send-email-benoit.thebaudeau@advansee.com>

Dear Beno?t Th?baudeau,

On Fri,  2 May 2014 16:59:24 +0200, Beno?t Th?baudeau wrote:

> These errors are caused by the glibc not being detected at configure time:
>   Testing C library type with cc ... done
>   Cannot determine C library type; assuming it is not glibc.

I think this commit was fixed by:

commit a13ea3b30b02580c0f582f2c2435818aa1921a3d
Author: Baruch Siach <baruch@tkos.co.il>
Date:   Wed May 14 15:45:08 2014 +0300

    lsof: don't use host toolchain to determine target libc
    
    The lsof Configure script builds a test program using the host toolchain to
    test whether glibc is used. This test is broken in cross compilation
    environment. Set LINUX_CLIB to avoid the test. This should give the correct
    result even for non glibc toolchains, since all libc variants we support have
    the netinet/tcp.h header.
    
    Fixes:
    http://autobuild.buildroot.net/results/a1f/a1f0572dbf968c21f70b35cefff7ef7a1d9a348a/
    
    Cc: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
    Signed-off-by: Baruch Siach <baruch@tkos.co.il>
    Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
    Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

At least, using a configuration similar to the one you pointed as failing
(http://autobuild.buildroot.org/results/ade/ade3629f72bf2195bde086a8c403197c0d1fdba3/),
I am not able to reproduce the problem.

I've therefore marked the patch as Rejected. If you still have the
issue, do not hesitate to get back to us.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-06-09 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02 14:59 [Buildroot] [PATCH] lsof: do not remove WIDECHARINCL definition Benoît Thébaudeau
2014-05-02 14:59 ` [Buildroot] [PATCH] lsof: fix "'TCP_*' undeclared" build errors Benoît Thébaudeau
2014-05-02 15:29   ` Benoît Thébaudeau
2014-05-02 15:50     ` Benoît Thébaudeau
2014-05-02 16:27     ` Benoît Thébaudeau
2014-06-09 13:20   ` Thomas Petazzoni [this message]
2014-06-09 13:07 ` [Buildroot] [PATCH] lsof: do not remove WIDECHARINCL definition Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140609152000.40043f97@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.