From: Mark Brown <broonie@kernel.org>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: dapm: Make sure register value is in sync with DAPM kcontrol state
Date: Mon, 9 Jun 2014 20:57:52 +0100 [thread overview]
Message-ID: <20140609195752.GL5099@sirena.org.uk> (raw)
In-Reply-To: <1402312829-1163-1-git-send-email-jarkko.nikula@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 592 bytes --]
On Mon, Jun 09, 2014 at 02:20:29PM +0300, Jarkko Nikula wrote:
> Commit c9e065c27fe9 ("ASoC: dapm: Make sure to always update the DAPM graph
> in _put_volsw()") stopped updating register values in those cases where
> initial after boot state of kcontrol appears to not change but where
> register value still needs update because it is not in sync with the
> kcontrol state.
Applied, thanks. One thing...
> - int connect, change;
> + int connect, change, reg_change = 0;
It's better not to mix initialisations in with other variable
declarations, it's a bit messy and marginally unclear.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-06-09 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 11:20 [PATCH] ASoC: dapm: Make sure register value is in sync with DAPM kcontrol state Jarkko Nikula
2014-06-09 11:54 ` Lars-Peter Clausen
2014-06-09 19:57 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609195752.GL5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.