All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	"bensberg@justemail.net" <bensberg@justemail.net>
Subject: Re: [PATCH 1/2] tests: fix left-over e2fsprogs-tmp files not getting clean up
Date: Mon, 9 Jun 2014 21:41:34 -0400	[thread overview]
Message-ID: <20140610014134.GC8092@thunk.org> (raw)
In-Reply-To: <3A214723-2502-4839-A68F-2566DE6AD6CE@dilger.ca>

On Mon, Jun 09, 2014 at 06:47:51PM -0600, Andreas Dilger wrote:
> 
> It would also be good to fix the "make clean" rule to clean up
> these temp files. 

The second patch should take care of nuking them the temp file when
the user types control-C.  I wouldn't be against deleting tmp files in
the build directory, but I wouldn't want to delete files in /tmp as
part of a make clean rule --- consider what might happen if the the
user types "make clean" in one build tree while running "make check"
in another.

					- Ted

      reply	other threads:[~2014-06-10  1:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 12:28 [PATCH] tests: for mktemp the exes must be the final characters of the name Benno Schulenberg
2014-06-04 22:31 ` Andreas Dilger
2014-06-05  3:28   ` Theodore Ts'o
2014-06-09 14:49   ` Theodore Ts'o
2014-06-09 14:50     ` [PATCH 1/2] tests: fix left-over e2fsprogs-tmp files not getting clean up Theodore Ts'o
2014-06-09 14:50       ` [PATCH 2/2] tests: clean up the temp file if test_one is interrupted Theodore Ts'o
2014-06-09 20:34       ` [PATCH 1/2] tests: fix left-over e2fsprogs-tmp files not getting clean up Andreas Dilger
2014-06-09 23:45         ` Theodore Ts'o
2014-06-10  0:47           ` Andreas Dilger
2014-06-10  1:41             ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140610014134.GC8092@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=bensberg@justemail.net \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.