From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
devel@driverdev.osuosl.org, linux-usb@vger.kernel.org,
navin patidar <navinp@cdac.in>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call
Date: Tue, 10 Jun 2014 09:57:35 +0300 [thread overview]
Message-ID: <20140610065735.GF5500@mwanda> (raw)
In-Reply-To: <1401917989-3427-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Wed, Jun 04, 2014 at 11:39:49PM +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> This was partly found using a static code analysis program called cppcheck.
>
We already knew that the string was NUL terminated because we checked
strnlen() on the lines before.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-10 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 21:39 [PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call Rickard Strandqvist
2014-06-10 6:57 ` Dan Carpenter [this message]
2014-06-10 20:48 ` Rickard Strandqvist
2014-06-11 5:45 ` Dan Carpenter
2014-06-12 21:09 ` Rickard Strandqvist
2014-06-12 21:39 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610065735.GF5500@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=navinp@cdac.in \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.