Re: rt2800usb: scheduling while atomic

[Stanislaw Gruszka <sgruszka@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On Tue, Jun 10, 2014 at 10:26:56AM +0200, Pontus Fuchs wrote:
> I have a reproducible sleep in atomic when I set up hostapd with
> TKIP on a rt2800 based USB dongle. As soon as a client connects I
> see this. I guess get_tkip_seq may not sleep.

Someone else reported that already, but fails to test provided patch:
http://rt2x00.serialmonkey.com/pipermail/users_rt2x00.serialmonkey.com/2014-January/006538.html

Does attached patch make the problem gone for you?

Thanks
Stanislaw


[-- Attachment #2: rt2x00_disable_tkip_on_usb.patch --]
[-- Type: text/plain, Size: 527 bytes --]

diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
index 2183e79..87d7938 100644
--- a/drivers/net/wireless/rt2x00/rt2x00mac.c
+++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
@@ -489,6 +489,8 @@ int rt2x00mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
 	crypto.cipher = rt2x00crypto_key_to_cipher(key);
 	if (crypto.cipher == CIPHER_NONE)
 		return -EOPNOTSUPP;
+	if (crypto.cipher == CIPHER_TKIP && rt2x00_is_usb(rt2x00dev))
+		return -EOPNOTSUPP;
 
 	crypto.cmd = cmd;