All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank
Date: Tue, 10 Jun 2014 14:47:29 +0300	[thread overview]
Message-ID: <20140610114729.GA27580@intel.com> (raw)
In-Reply-To: <20140610113348.GA22223@nuc-i3427.alporthouse.com>

On Tue, Jun 10, 2014 at 12:33:48PM +0100, Chris Wilson wrote:
> On Tue, Jun 10, 2014 at 02:25:50PM +0300, Ville Syrjälä wrote:
> > On Tue, Jun 10, 2014 at 11:04:00AM +0100, Chris Wilson wrote:
> > > +static inline int crtc_sbc(struct intel_crtc *crtc)
> > > +{
> > > +	return atomic_read(&crtc->base.dev->vblank[crtc->pipe].count);
> > > +}
> > 
> > Still says 'sbc' which doesn't make sense to me.
> 
> I just don't like the term msc. :-p
> crtc_vblank_counter()?

Maybe stick it into drmP.h and call it drm_crtc_vblank_counter() or
something? Hopefully people won't confuse it with the hardware counter.

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2014-06-10 11:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 10:04 [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank Chris Wilson
2014-06-10 10:04 ` [PATCH 2/3] drm/i915: Decouple the stuck pageflip on modeset Chris Wilson
2014-06-10 11:29   ` Ville Syrjälä
2014-06-10 10:04 ` [PATCH 3/3] drm/i915: Boost GPU frequency if we detect outstanding pageflips Chris Wilson
2014-06-10 11:41   ` Ville Syrjälä
2014-06-10 11:49     ` Chris Wilson
2014-06-10 12:32   ` Ville Syrjälä
2014-06-10 11:25 ` [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank Ville Syrjälä
2014-06-10 11:33   ` Chris Wilson
2014-06-10 11:47     ` Ville Syrjälä [this message]
2014-06-10 13:26       ` Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2014-06-10 12:46 Chris Wilson
2014-06-10 13:46 ` Ville Syrjälä
2014-05-30 16:16 Chris Wilson
2014-06-09 13:06 ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140610114729.GA27580@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.