From: Dan Carpenter <dan.carpenter@oracle.com>
To: inki.dae@samsung.com
Cc: linux-samsung-soc@vger.kernel.org
Subject: re: drm/exynos: consider deferred probe case
Date: Tue, 10 Jun 2014 15:38:38 +0300 [thread overview]
Message-ID: <20140610123837.GA7854@mwanda> (raw)
Hello Inki Dae,
The patch df5225bc9a87: "drm/exynos: consider deferred probe case"
from May 29, 2014, leads to the following static checker warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:996 fimd_probe()
warn: 'ctx->display' isn't an ERR_PTR
drivers/gpu/drm/exynos/exynos_drm_fimd.c
994
995 ctx->display = exynos_dpi_probe(dev);
996 if (IS_ERR(ctx->display))
997 return PTR_ERR(ctx->display);
998
Smatch is complaining because my config has CONFIG_DRM_EXYNOS_DPI
disabled.
1) If CONFIG_DRM_EXYNOS_DPI isn't enabled, we still return "0". That
will cause a Sparse warning.
2) Also there are still a number of checks for "if (ctx->display)".
Those things are weird to me, are those checks to see
CONFIG_DRM_EXYNOS_DPI is enabled or are they checking that
exynos_dpi_probe() succeeded?
regards,
dan carpenter
next reply other threads:[~2014-06-10 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 12:38 Dan Carpenter [this message]
2014-06-11 6:12 ` drm/exynos: consider deferred probe case Inki Dae
2014-06-11 6:36 ` [patch] drm/exynos: change zero to NULL for sparse Dan Carpenter
2014-06-11 6:36 ` Dan Carpenter
2014-06-18 5:06 ` Inki Dae
2014-06-18 5:06 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610123837.GA7854@mwanda \
--to=dan.carpenter@oracle.com \
--cc=inki.dae@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.