From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/5] drm/i915: enable fastboot by default Date: Tue, 10 Jun 2014 16:10:46 +0200 Message-ID: <20140610141046.GS5821@phenom.ffwll.local> References: <1401992671-2548-1-git-send-email-jbarnes@virtuousgeek.org> <1401992671-2548-5-git-send-email-jbarnes@virtuousgeek.org> <87ppimcmvn.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F1A06E6B7 for ; Tue, 10 Jun 2014 07:10:52 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id r20so6207421wiv.7 for ; Tue, 10 Jun 2014 07:10:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87ppimcmvn.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Jesse Barnes List-Id: dri-devel@lists.freedesktop.org On Fri, Jun 06, 2014 at 02:12:44PM +0300, Jani Nikula wrote: > On Thu, 05 Jun 2014, Jesse Barnes wrote: > > Let them eat mincemeat pie. > > > > Signed-off-by: Jesse Barnes > > --- > > drivers/gpu/drm/i915/i915_params.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > > index d05a2af..081ab2f 100644 > > --- a/drivers/gpu/drm/i915/i915_params.c > > +++ b/drivers/gpu/drm/i915/i915_params.c > > @@ -41,7 +41,7 @@ struct i915_params i915 __read_mostly = { > > .preliminary_hw_support = IS_ENABLED(CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT), > > .disable_power_well = 1, > > .enable_ips = 1, > > - .fastboot = 0, > > + .fastboot = 42, > > The answer to the ultimate question of life, the universe, and > everything should simply be "true" here. Personally, I don't think it's > a bad answer. > > > .prefault_disable = 0, > > .reset = true, > > .invert_brightness = 0, > > @@ -132,7 +132,7 @@ MODULE_PARM_DESC(enable_ips, "Enable IPS (default: true)"); > > > > module_param_named(fastboot, i915.fastboot, bool, 0600); > > Side note, why do we allow the param to be changed after boot? Because fastboot works for every modeset, or at least should. E.g. if you go from an upscale panel resolotion to the full one we still want to just fixup the pfit, even when it's a normal modeset. So fastboot really is a bit a misnomer, since the leftover bits (after I've convinced Jesse that the fb takeover should be done unconditionally really) is just some modeset fastpaths. Aside: We still have a leak on the inherited fb, see https://bugs.freedesktop.org/show_bug.cgi?id=77511 -Daniel > > BR, > Jani. > > > MODULE_PARM_DESC(fastboot, > > - "Try to skip unnecessary mode sets at boot time (default: false)"); > > + "Try to skip unnecessary mode sets at boot time (default: true)"); > > > > module_param_named(prefault_disable, i915.prefault_disable, bool, 0600); > > MODULE_PARM_DESC(prefault_disable, > > -- > > 1.8.3.2 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch