Re: [Patch v2] xfce4-screenshooter: Ensure lib directory exists.

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2484 bytes --]

On Tue, Jun 10, 2014 at 09:42:17AM -0700, Ash Charles wrote:
> Hi,
> 
> Newbie question:
> I sent this correction as a v2 on the patch as committed on
> master-next (which, unintentionally meant that I carried over Martin's
> SOB).  Is this the correct approach or

I don't mind my SOB being carried (I can still remove it when
re-cherry-picking to master next)

> 1. would you rather a completely new patch to resolve just the issue
> as the original has already been committed to master-next

No, being in master-next only means that it's being tested in my Jenkins
builds, I'm rebasing master-next every time I push something to master,
so I'll just replace original patch with v2 in master-next for next Jenkins
build.

> 2. would you rather a v2 on the original patch I sent to the list?

Sending PATCHv2 with --in-reply-to as you did now, is the best for me, thanks

> thanks,
> --Ash
> 
> On Tue, Jun 10, 2014 at 9:36 AM, Ash Charles <ashcharles@gmail.com> wrote:
> > Screenshooter autogenerates screenshooter-marshal.[ch] in lib/ during
> > compilation.  The source directory contains a lib/ but this directory
> > doesn't exist in a build directory by default so we add one manually.
> > Really, this should be corrected in the upstream package.
> >
> > v2: only make lib/ if it doesn't exist
> >
> > Upstream-Status: pending
> >
> > Signed-off-by: Ash Charles <ashcharles@gmail.com>
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  .../recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb     | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
> > index 4cda352..0e2e327 100644
> > --- a/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
> > +++ b/meta-xfce/recipes-apps/xfce4-screenshooter/xfce4-screenshooter_1.8.1.bb
> > @@ -11,5 +11,9 @@ SRC_URI += "file://0001-Fix-panel-plugin-build.patch"
> >  SRC_URI[md5sum] = "d0ffea2052a8e70154cf13789070711f"
> >  SRC_URI[sha256sum] = "40419892bd28989315eed053c159bba0f4264ed8c6c6738806024e481eab9492"
> >
> > +do_compile_prepend() {
> > +       mkdir -p lib
> > +}
> > +
> >  FILES_${PN} += "${datadir}/xfce4/panel/plugins \
> >          ${libdir}/xfce4/panel/plugins"
> > --
> > 1.8.3.2
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]