From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [RFC][PATCH] debugfs: Fix corrupted loop in debugfs_remove_recursive Date: Tue, 10 Jun 2014 13:23:02 -0700 Message-ID: <20140610202302.GB20499@kroah.com> References: <20140609140607.3e3aae39@gandalf.local.home> <20140610093357.7ef3792b@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , LKML , linux-fsdevel@vger.kernel.org, Andrew Morton To: Steven Rostedt Return-path: Content-Disposition: inline In-Reply-To: <20140610093357.7ef3792b@gandalf.local.home> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jun 10, 2014 at 09:33:57AM -0400, Steven Rostedt wrote: > On Mon, 9 Jun 2014 14:06:07 -0400 > Steven Rostedt wrote: > > > [ I'm currently running my tests on it now, and so far, after a few > > hours it has yet to blow up. I'll run it for 24 hours which it never > > succeeded in the past. ] > > I ran with this patch on three boxes all night, one for 24 hours. No > problems. I stopped the tests, removed the patch, ran the test on the > same boxes and they all crashed within an hour. > > This patch definitely fixes the bug. > > The test I ran was: > > while :; do > ./ftrace-test-mkinstances || break > ./ftrace-test-mkinstances-2 || break > done > > Note, the tests expect debugfs to be mounted at /debug. Well, those are some broken tests :) Anyway, thanks for the patch, I'll queue it up after 3.16-rc1 is out. greg k-h