diff for duplicates of <20140611081317.GA29444@mwanda> diff --git a/a/1.txt b/N1/1.txt index eb7fbd7..71848e7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -29,11 +29,11 @@ index 3b5bacd..2b6a9ce 100644 @@ -528,15 +527,16 @@ static u8 at91_adc_get_trigger_value_by_name(struct iio_dev *idev, return -ENOMEM; - if (strcmp(trigger_name, name) = 0) { + if (strcmp(trigger_name, name) == 0) { - value = triggers[i].value; kfree(name); - break; -+ if (triggers[i].value = 0) ++ if (triggers[i].value == 0) + return -EINVAL; + return triggers[i].value; } @@ -57,7 +57,7 @@ index 3b5bacd..2b6a9ce 100644 value = at91_adc_get_trigger_value_by_name(idev, st->trigger_list, idev->trig->name); -- if (value = 0) +- if (value == 0) - return -EINVAL; + if (value < 0) + return value; diff --git a/a/content_digest b/N1/content_digest index 83c5f28..69a1620 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\053980711.5030604@bfs.de\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[patch v2] iio: adc: at91: signedness bug in at91_adc_get_trigger_value_by_name()\0" - "Date\0Wed, 11 Jun 2014 08:13:17 +0000\0" + "Date\0Wed, 11 Jun 2014 11:13:17 +0300\0" "To\0Jonathan Cameron <jic23@kernel.org>\0" "Cc\0Grant Likely <grant.likely@linaro.org>" Rob Herring <robh+dt@kernel.org> @@ -48,11 +48,11 @@ "@@ -528,15 +527,16 @@ static u8 at91_adc_get_trigger_value_by_name(struct iio_dev *idev,\n" " \t\t\treturn -ENOMEM;\n" " \n" - " \t\tif (strcmp(trigger_name, name) = 0) {\n" + " \t\tif (strcmp(trigger_name, name) == 0) {\n" "-\t\t\tvalue = triggers[i].value;\n" " \t\t\tkfree(name);\n" "-\t\t\tbreak;\n" - "+\t\t\tif (triggers[i].value = 0)\n" + "+\t\t\tif (triggers[i].value == 0)\n" "+\t\t\t\treturn -EINVAL;\n" "+\t\t\treturn triggers[i].value;\n" " \t\t}\n" @@ -76,7 +76,7 @@ " \tvalue = at91_adc_get_trigger_value_by_name(idev,\n" " \t\t\t\t\t\t st->trigger_list,\n" " \t\t\t\t\t\t idev->trig->name);\n" - "-\tif (value = 0)\n" + "-\tif (value == 0)\n" "-\t\treturn -EINVAL;\n" "+\tif (value < 0)\n" "+\t\treturn value;\n" @@ -84,4 +84,4 @@ " \tif (state) {\n" " \t\tst->buffer = kmalloc(idev->scan_bytes, GFP_KERNEL);" -4117bbd32d7cc290e17b712b148707a1d078700ce58f59bccd76b6500e65024f +c5731f08c37c4869e8c147f3adcd093547b65dcc5ff4bead55a380f1f602ebb1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.