From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH V2 0/3] virtio-net: announce self by guest
Date: Wed, 11 Jun 2014 17:42:21 +0300 [thread overview]
Message-ID: <20140611144221.GA27060@redhat.com> (raw)
In-Reply-To: <1400565704-11592-1-git-send-email-jasowang@redhat.com>
On Tue, May 20, 2014 at 02:01:41PM +0800, Jason Wang wrote:
> Hi all:
>
> This series tries to do the announcing by guest through virito-net. This is done
> through inject the notificaiton interrupt to guest several times after migration
> and then guest driver will send the proper garp packets.
>
> Recent Linux driver has already had this support.
>
> Tested with ping to guest with vlan during migration. Without the
> patch, lots of the packets were lost after migration. With the patch,
> could not notice packet loss after migration.
>
> Reference:
> V1: https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg02975.html
> RFC v2: https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01750.html
> RFC v1: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02648.html
> V7: https://lists.gnu.org/archive/html/qemu-devel/2013-03/msg01127.html
>
> Changes from V1:
> - check the guest feature and schedule the timer immediately on load()
> - drop the logic form QEMU_CLEAK_REALTIME
> - use timer_new_ms() instead of timer_new_ns() (which is a bug of V1)
> - export SELF_ANNOUNCE_ROUNDS
> - introduce self_announce_delay()
> - typos
>
> Changes from RFC v2:
> - use QEMU_CLOCK_VIRTUAL instead of QEMU_CLOCK_REALTIME
> - compat self announce for 2.0 machine type
>
> Changes from RFC v1:
> - clean VIRTIO_NET_S_ANNOUNCE bit during reset
> - free announce timer during clean
> - make announce work for non-vhost case
>
> Changes from V7:
> - Instead of introducing a global method for each kind of nic, this
> version limits the changes to virtio-net itself.
>
> Jason Wang (3):
> migration: export SELF_ANNOUNCE_ROUNDS
> migration: introduce self_announce_delay()
> virtio-net: announce self by guest
Applied, thanks!
> hw/net/virtio-net.c | 42 ++++++++++++++++++++++++++++++++++++++++
> include/hw/i386/pc.h | 5 ++++
> include/hw/virtio/virtio-net.h | 17 ++++++++++++++++
> include/migration/vmstate.h | 10 +++++++++
> savevm.c | 3 +-
> 5 files changed, 75 insertions(+), 2 deletions(-)
prev parent reply other threads:[~2014-06-11 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 6:01 [Qemu-devel] [PATCH V2 0/3] virtio-net: announce self by guest Jason Wang
2014-05-20 6:01 ` [Qemu-devel] [PATCH V2 1/3] migration: export SELF_ANNOUNCE_ROUNDS Jason Wang
2014-05-20 6:01 ` [Qemu-devel] [PATCH V2 2/3] migration: introduce self_announce_delay() Jason Wang
2014-05-20 6:01 ` [Qemu-devel] [PATCH V2 3/3] virtio-net: announce self by guest Jason Wang
2014-06-10 6:20 ` Amit Shah
2014-06-10 10:10 ` Michael S. Tsirkin
2014-06-11 2:50 ` Jason Wang
2014-06-13 12:35 ` Amit Shah
2014-06-11 14:42 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611144221.GA27060@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.