From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: [PATCH ARM v3 1/7] mini-os: build fixes Date: Wed, 11 Jun 2014 21:02:22 +0200 Message-ID: <20140611190222.GI6816@type.mobile.lan> References: <1402482618-15269-1-git-send-email-talex5@gmail.com> <1402482618-15269-2-git-send-email-talex5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wup4e-0006Qc-Ly for xen-devel@lists.xenproject.org; Wed, 11 Jun 2014 20:24:44 +0000 Content-Disposition: inline In-Reply-To: <1402482618-15269-2-git-send-email-talex5@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Thomas Leonard Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, Dave.Scott@eu.citrix.com, anil@recoil.org List-Id: xen-devel@lists.xenproject.org Thomas Leonard, le Wed 11 Jun 2014 11:30:12 +0100, a =E9crit : > Make .o rules depend on the includes. Before, only the final link step > depended on setting up the includes directory, making parallel builds > unreliable. > = > Make symlinks use explicit make rules instead of using a phony target. > Avoids unnecessary rebuilds. > = > Signed-off-by: Thomas Leonard This makes sense, just one thing: > +LINKS =3D include/list.h $(ARCH_LINKS) include/mini-os include/xen inclu= de/$(TARGET_ARCH_FAM)/mini-os > + > +EXTRA_DEPS +=3D $(LINKS) include/list.h > + include/list.h thus appears twice in EXTRA_DEPS. I guess there is no need for an intermediate LINKS variable. Samuel