From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH ARM v3 5/7] mini-os: switched initial C
 entry point to arch_init
Date: Wed, 11 Jun 2014 21:09:45 +0200
Message-ID: <20140611190945.GK6816@type.mobile.lan>
References: <1402482618-15269-1-git-send-email-talex5@gmail.com>
	<1402482618-15269-6-git-send-email-talex5@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72) (envelope-from
	<SRS0=G/WP=3I=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1Wup4L-0006Mz-Du
	for xen-devel@lists.xenproject.org; Wed, 11 Jun 2014 20:24:25 +0000
Content-Disposition: inline
In-Reply-To: <1402482618-15269-6-git-send-email-talex5@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Thomas Leonard <talex5@gmail.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, Dave.Scott@eu.citrix.com, anil@recoil.org
List-Id: xen-devel@lists.xenproject.org

Thomas Leonard, le Wed 11 Jun 2014 11:30:16 +0100, a =E9crit :
> arch_print_info (a debug print called during start up) was also removed.

Well, this information is quite useful, like start_info etc. pointers.
Please bring it back.

> @@ -87,14 +88,40 @@ static inline void sse_init(void) {
>  #define sse_init()
>  #endif
>  =

> +
> +void start_kernel(void);
> +

This shouldn't be needed any more.

> @@ -201,13 +174,12 @@ void stop_kernel(void)
>      /* Reset events. */
...
>  }
>  =

> +void arch_do_exit(void);

Ditto.

Apart from that,

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Samuel