From: Dimitri Sivanich <sivanich@sgi.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/misc/sgi-gru/grukdump.c: remove unnecessary test on unsigned int
Date: Wed, 11 Jun 2014 14:44:07 -0500 [thread overview]
Message-ID: <20140611194407.GA10097@sgi.com> (raw)
In-Reply-To: <1402512422-15990-1-git-send-email-fabf@skynet.be>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Wed, Jun 11, 2014 at 08:47:02PM +0200, Fabian Frederick wrote:
> unsigned value is never < 0
>
> Cc: Dimitri Sivanich <sivanich@sgi.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/misc/sgi-gru/grukdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
> index a3700a5..e0e0e7e 100644
> --- a/drivers/misc/sgi-gru/grukdump.c
> +++ b/drivers/misc/sgi-gru/grukdump.c
> @@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
> return -EFAULT;
>
> /* Currently, only dump by gid is implemented */
> - if (req.gid >= gru_max_gids || req.gid < 0)
> + if (req.gid >= gru_max_gids)
> return -EINVAL;
>
> gru = GID_TO_GRU(req.gid);
> --
> 1.8.4.5
prev parent reply other threads:[~2014-06-11 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 18:47 [PATCH 1/1] drivers/misc/sgi-gru/grukdump.c: remove unnecessary test on unsigned int Fabian Frederick
2014-06-11 19:44 ` Dimitri Sivanich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611194407.GA10097@sgi.com \
--to=sivanich@sgi.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.