Re: [PATCH igt 1/4] lib/igt_debugfs: Don't fail if debugfs is already mounted

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Jun 11, 2014 at 07:41:17PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Remove the igt_assert() from the debugfs mount. It will fail if debugfs
> is already mounted. With the assert in place it's very annying to use
> igt without i915 loaded (eg. to dump BIOS configured registers).
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  lib/igt_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
> index f21f671..809d447 100644
> --- a/lib/igt_debugfs.c
> +++ b/lib/igt_debugfs.c
> @@ -102,7 +102,7 @@ static bool __igt_debugfs_init(igt_debugfs_t *debugfs)
>  
>  	igt_assert(stat("/sys/kernel/debug", &st) == 0);
>  
> -	igt_assert(mount("debug", "/sys/kernel/debug", "debugfs", 0, 0) == 0);
> +	mount("debug", "/sys/kernel/debug", "debugfs", 0, 0);

Hm, for me this just silently succeeds. Maybe just an igt_warn_on? But I'm
ok with this here, too.
-Daniel

>  
>  find_minor:
>  	strcpy(debugfs->root, path);
> -- 
> 1.8.5.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch