From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Subject: Re: [PATCH v2 2/5] acpi, apei, ghes: Introduce ACPI_APEI_NMI to make NMI error notification a GHES feature. Date: Thu, 12 Jun 2014 12:32:38 +0200 Message-ID: <20140612103238.GB22583@rric.localhost> References: <1401262770-25343-1-git-send-email-tomasz.nowicki@linaro.org> <1401262770-25343-3-git-send-email-tomasz.nowicki@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1401262770-25343-3-git-send-email-tomasz.nowicki@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Tomasz Nowicki Cc: rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, bp@alien8.de, m.chehab@samsung.com, bp@suse.de, linux-edac@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org List-Id: linux-acpi@vger.kernel.org On 28.05.14 09:39:27, Tomasz Nowicki wrote: > +config ACPI_APEI_NMI > + bool "NMI error notification support" > + default y > + depends on ACPI_APEI_GHES && X86 > + help > + Firmware first mode can use NMI notification mechanism to report errors > + to operating system. This feature is currently supported by X86 > + architecture only. > + This selection is not necessary. I don't see why one should select this at all. It's either there for an arch or not. Just use ARCH_HAS_ style and and hard select ARCH_HAS_ACPI_APEI_NMI for x86. There is no need for the ACPI_APEI_GHES dependency then. -Robert