From: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: The netfilter developer mailinglist
<netfilter-devel@vger.kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [RFC PATCH 1/1 libnetfilter_conntrack] zero value handling of mark and zone
Date: Thu, 12 Jun 2014 22:43:28 +0900 [thread overview]
Message-ID: <20140612134328.GA24379@gmail.com> (raw)
In-Reply-To: <20140612115925.GB1982@breakpoint.cc>
On Thu, Jun 12, 2014 at 01:59:25PM +0200, Florian Westphal wrote:
> > > ct1 and ct2 zones would then always be equal except if
> > > both have ATTR_ZONE set and the zones are different.
> >
> > I think it reasonable too, but attr holds old value if it was unset.
>
> Yes, but nfct_get_attr_u* return 0 if attribute bit is unset.
That's why you do not use the raw value. I should have understood
it earlyer, sorry.
> So I think this should work.
I agree with you, thank you.
Should we clear errno in that cmp_zone() before return?
next prev parent reply other threads:[~2014-06-12 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 23:42 [RFC PATCH 1/1 libnetfilter_conntrack] zero value handling of mark and zone Ken-ichirou MATSUZAWA
2014-06-12 0:18 ` Florian Westphal
2014-06-12 5:19 ` Ken-ichirou MATSUZAWA
2014-06-12 9:48 ` Florian Westphal
2014-06-12 11:33 ` Ken-ichirou MATSUZAWA
2014-06-12 11:59 ` Florian Westphal
2014-06-12 13:43 ` Ken-ichirou MATSUZAWA [this message]
2014-06-12 14:05 ` Florian Westphal
2014-06-12 23:12 ` Ken-ichirou MATSUZAWA
2014-06-16 0:04 ` Ken-ichirou MATSUZAWA
2014-06-16 11:41 ` Florian Westphal
2014-06-16 13:20 ` Ken-ichirou MATSUZAWA
2014-06-16 13:24 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612134328.GA24379@gmail.com \
--to=chamaken@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.