From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wahib Faizi <wahibfaizi@gmail.com>
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style
Date: Thu, 12 Jun 2014 07:10:50 -0700 [thread overview]
Message-ID: <20140612141050.GA7203@kroah.com> (raw)
In-Reply-To: <1402569338-5709-2-git-send-email-wahibfaizi@gmail.com>
On Thu, Jun 12, 2014 at 02:35:38PM +0400, Wahib Faizi wrote:
> Fix coding style issues detected by checkpatch.pl:
> 1. do not use assignment in if condition
> 2. line over 80 characters
You are doing two different things here, so please break it up into two
different patches. Can you please do this and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2014-06-12 14:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Eudyptula Challenge (Task 10)>
2014-06-12 10:35 ` Eudyptula Challenge (Task 10) Wahib Faizi
2014-06-12 10:35 ` [PATCH] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style Wahib Faizi
2014-06-12 14:10 ` Greg Kroah-Hartman [this message]
2014-06-12 17:32 ` Split patch into 2 logical chunks Wahib Faizi
2014-06-12 17:32 ` [PATCH v2 1/2] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style Wahib Faizi
2014-06-12 17:54 ` Greg Kroah-Hartman
2014-06-12 17:55 ` Joe Perches
2014-06-12 17:32 ` [PATCH v2 2/2] " Wahib Faizi
2014-06-12 19:09 ` Fix subject line Wahib Faizi
2014-06-12 19:09 ` [PATCH 1/2] staging: usbip: usbip_host_driver.c: avoid assignment in if Wahib Faizi
2014-06-12 19:09 ` [PATCH 2/2] staging: usbip: usbip_host_driver.c: fix line over 80 characters Wahib Faizi
2014-06-12 19:40 ` [PATCH v3 0/2] Fix subject line Wahib Faizi
2014-06-12 19:40 ` [PATCH v3 1/2] staging: usbip: usbip_host_driver.c: avoid assignment in if Wahib Faizi
2014-06-12 19:40 ` [PATCH v3 2/2] staging: usbip: usbip_host_driver.c: fix line over 80 characters Wahib Faizi
2014-06-12 20:25 ` [PATCH v3 0/2] Fix subject line Davidlohr Bueso
2014-06-12 20:35 ` Greg Kroah-Hartman
2014-06-12 20:48 ` Davidlohr Bueso
2014-06-12 21:30 ` Dan Carpenter
2014-06-15 20:28 ` Wahib
2014-06-18 0:30 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612141050.GA7203@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=valentina.manea.m@gmail.com \
--cc=wahibfaizi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.