All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org
Subject: re: Input: psmouse - switch to using dev_*() for messages
Date: Thu, 12 Jun 2014 17:29:12 +0300	[thread overview]
Message-ID: <20140612142912.GA13103@mwanda> (raw)

Hello Dmitry Torokhov,

This is a semi-automatic email about new static checker warnings.

The patch b5d21704361e: "Input: psmouse - switch to using dev_*() for
messages" from Oct 10, 2011, leads to the following Smatch complaint:

drivers/input/mouse/psmouse-base.c:1512 psmouse_reconnect()
	 error: we previously assumed 'psmouse' could be null (see line 1511)

drivers/input/mouse/psmouse-base.c
  1510	
  1511		if (!drv || !psmouse) {
                             ^^^^^^^
Old check.

  1512			psmouse_dbg(psmouse,
                                    ^^^^^^^
New dereference.

  1513				    "reconnect request, but serio is disconnected, ignoring...\n");
  1514			return -1;

regards,
dan carpenter

                 reply	other threads:[~2014-06-12 14:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140612142912.GA13103@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.