From: Greg KH <greg@kroah.com>
To: Ulrik De Bie <ulrik.debie-os@e2big.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
stable@vger.kernel.org, linux-input@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
David Herrmann <dh.herrmann@gmail.com>
Subject: Re: [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models
Date: Thu, 12 Jun 2014 11:48:44 -0700 [thread overview]
Message-ID: <20140612184844.GA25788@kroah.com> (raw)
In-Reply-To: <1402596901-28784-2-git-send-email-ulrik.debie-os@e2big.org>
On Thu, Jun 12, 2014 at 08:15:01PM +0200, Ulrik De Bie wrote:
> Some elantech v3 touchpad equipped laptops also have a trackpoint, before
> this commit, these give sync errors. With this patch, the trackpoint is
> provided as another input device: 'Elantech PS/2 TrackPoint'
>
> The patch will also output messages that do not follow the expected pattern.
> In the mean time I've seen 2 unknown packets occasionally:
> 0x04 , 0x00 , 0x00 , 0x00 , 0x00 , 0x00
> 0x00 , 0x00 , 0x00 , 0x02 , 0x00 , 0x00
> I don't know what those are for, but they can be safely ignored.
>
> Currently all packets that are not known to v3 touchpad and where
> packet[3] (the fourth byte) lowest nibble is 6 are now recognized as
> PACKET_TRACKPOINT and processed by the new elantech_report_trackpoint.
>
> This has been verified to work on a laptop Lenovo L530 where the
> touchpad/trackpoint combined identify themselves as:
> psmouse serio1: elantech: assuming hardware version 3 (with firmware version 0x350f02)
> psmouse serio1: elantech: Synaptics capabilities query result 0xb9, 0x15, 0x0c.
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ulrik De Bie <ulrik.debie-os@e2big.org>
> ---
> drivers/input/mouse/elantech.c | 104 +++++++++++++++++++++++++++++++++++++++--
> drivers/input/mouse/elantech.h | 4 ++
> 2 files changed, 105 insertions(+), 3 deletions(-)
This seems like a new feature to me and not a stable kernel patch. How
does this fit in with the Documentation/stable_kernel_rules.txt
requirements?
thanks,
greg k-h
next prev parent reply other threads:[~2014-06-12 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 20:51 [PATCH] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530 Ulrik De Bie
2014-03-20 19:59 ` ulrik.debie-os
2014-06-12 18:15 ` [PATCH v2 0/1] " Ulrik De Bie
2014-06-12 18:15 ` [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models Ulrik De Bie
2014-06-12 18:48 ` Greg KH [this message]
2014-06-12 19:03 ` ulrik.debie-os
2014-06-12 22:13 ` Greg KH
2014-06-13 6:24 ` David Herrmann
[not found] ` <539AA71D.2040808@redhat.com>
2014-06-13 7:39 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612184844.GA25788@kroah.com \
--to=greg@kroah.com \
--cc=dh.herrmann@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ulrik.debie-os@e2big.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.