From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, gregkh@linuxfoundation.org,
markh@compro.net, driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()
Date: Fri, 13 Jun 2014 11:00:17 +0300 [thread overview]
Message-ID: <20140613080017.GC5015@mwanda> (raw)
In-Reply-To: <20140613074147.GA31615@devel.8.8.4.4>
On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote:
> dgap_tty_unregister() will unregister serial_driver
> and print_driver, and also free related variables.
>
Introducing a static function without a caller will cause a GCC warning
about unused functions.
Fold 5,7 and 8 together into one patch. This is still "one thing per
patch" because they can't be done separately.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-13 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 7:41 [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister() Daeseok Youn
2014-06-13 8:00 ` Dan Carpenter [this message]
2014-06-13 8:16 ` DaeSeok Youn
2014-06-13 8:38 ` Dan Carpenter
2014-06-13 8:50 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613080017.GC5015@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.