From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, gregkh@linuxfoundation.org,
markh@compro.net, driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] staging: dgap: introduce dgap_release_remap()
Date: Fri, 13 Jun 2014 11:33:53 +0300 [thread overview]
Message-ID: <20140613083353.GE5015@mwanda> (raw)
In-Reply-To: <20140613074411.GA31639@devel.8.8.4.4>
On Fri, Jun 13, 2014 at 04:44:11PM +0900, Daeseok Youn wrote:
> The dgap_found_board() did request some memory region and
> call ioremap, these should be released and unmaped
> when one of functions which are called after dgap_found_board()
> in dgap_init_one() is failed.
>
Oh... Here you clean up the rest that I mentioned in reviewing 8/9.
Fine fine.
regards,
dan carpenter
prev parent reply other threads:[~2014-06-13 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 7:44 [PATCH 9/9] staging: dgap: introduce dgap_release_remap() Daeseok Youn
2014-06-13 8:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613083353.GE5015@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.