All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: JP Abgrall <jpa@google.com>, Eric Sandeen <sandeen@redhat.com>,
	linux-ext4@vger.kernel.org, Geremy Condra <gcondra@google.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] ext4: Add support for SFITRIM, an ioctl for secure FITRIM.
Date: Fri, 13 Jun 2014 10:31:57 -0400	[thread overview]
Message-ID: <20140613143157.GB23180@thunk.org> (raw)
In-Reply-To: <20140613142054.GA23180@thunk.org>

On Fri, Jun 13, 2014 at 10:20:54AM -0400, Theodore Ts'o wrote:
> 
> If you really want this to work, and be 100% secure, you really need
> to do the secure discard at the file system layer.  The file system
> could make sure that every single block gets a secure discard before
> it gets reused.

BTW, one major downside of doing a secure trim after every time that a
block has been released is that it will massively increase the flash
wear, since if you do a secure trim on a single 4k block in 512k erase
block, assuming that secure trim has been implemented properly from a
security perspective, it will need to copy out all of the used portion
of the 512k erase block, and then erase it.

This is one of the reasons why I asked if you really need to worry
about securely discarding all of the blocks on the file system, or
just blocks containing specific really security-sensitive information
(i.e., for Google Wallet, etc.)

If so, you might be better off either doing per-file encryption, or
per-file secure discard.

Cheers,

					- Ted

  reply	other threads:[~2014-06-13 14:32 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  2:14 [PATCH] ext4: Add support for SFITRIM, an ioctl for secure FITRIM JP Abgrall
2014-06-13  2:36 ` Darrick J. Wong
2014-06-13  2:57   ` JP Abgrall
2014-06-13  2:36 ` Eric Sandeen
2014-06-13  3:02   ` JP Abgrall
2014-06-13  3:12     ` Eric Sandeen
2014-06-13  3:19       ` JP Abgrall
2014-06-13  3:24         ` Eric Sandeen
2014-06-13  4:37           ` JP Abgrall
2014-06-13  3:15   ` Dave Chinner
2014-06-13  3:30     ` Dave Chinner
2014-06-13  4:37       ` JP Abgrall
2014-06-13  5:07         ` Dave Chinner
2014-06-13 14:20           ` Theodore Ts'o
2014-06-13 14:31             ` Theodore Ts'o [this message]
2014-06-13 19:44               ` JP Abgrall
2014-06-13 19:57                 ` Eric Sandeen
2014-06-13 20:12                   ` JP Abgrall
2014-06-13 23:41                 ` Theodore Ts'o
2014-06-14  0:46                   ` JP Abgrall
2014-06-17  2:49                   ` Dave Chinner
2014-06-17 11:27                     ` Theodore Ts'o
2014-06-17 11:55                     ` Lukáš Czerner
2014-06-17 12:46                       ` Theodore Ts'o
2014-06-17 13:00                         ` Lukáš Czerner
2014-06-17 13:54                           ` Theodore Ts'o
2014-06-17 17:53                             ` JP Abgrall
2014-06-18  9:33                               ` Lukáš Czerner
2014-06-18 21:51                                 ` JP Abgrall
2014-06-19  8:10                                   ` Lukáš Czerner
2014-06-18 22:06                                 ` Theodore Ts'o
2014-06-19  0:36                                   ` Dave Chinner
2014-06-19  8:15                                     ` Lukáš Czerner
2014-06-20  2:44                                       ` Martin K. Petersen
2014-06-19  8:33                                   ` Lukáš Czerner
2014-06-17 17:35                           ` JP Abgrall
2014-06-18  9:48 ` Lukáš Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140613143157.GB23180@thunk.org \
    --to=tytso@mit.edu \
    --cc=david@fromorbit.com \
    --cc=gcondra@google.com \
    --cc=jpa@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.