Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs
Date: Fri, 13 Jun 2014 18:54:02 +0300	[thread overview]
Message-ID: <20140613155402.GA27580@intel.com> (raw)
In-Reply-To: <1402673558-15618-1-git-send-email-jbarnes@virtuousgeek.org>

On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote:
> Early revs didn't have PPGTT support, so disable there.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 8b3cde7..01287d9 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
>  	}
>  #endif
>  
> +	/* Early VLV doesn't have this */
> +	if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc)

Did you mean < 0xb?

> +		return 0;
> +
>  	return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
>  }
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC