From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: virtio-scsi issues duplicate tags when async_abort is enabled Date: Fri, 13 Jun 2014 11:52:21 -0700 Message-ID: <20140613185221.GA11872@infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: Venkatesh Srinivas Cc: hare@suse.de, hch@infradead.org, Paolo Bonzini , JBottomley@parallels.com, linux-scsi@vger.kernel.org, stable@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Fri, Jun 13, 2014 at 10:58:22AM -0700, Venkatesh Srinivas wrote: > CC-ing stable as 3.14 and 3.15 are affected; a conservative fix is to > enable no_async_abort until the problem is better-understood. No patch attached. Nevermind this is not a consdervative fix, but a band aid. The proper fix is to figure out what's actually going on here. >>From your trace above it very much looks like a double completion of some sort. I've looked at the virtio-scsi code a bit, and one odd thing it does that comes in handy here is that it doesn't really use a traditional tag, but rather the address of the scsi command. Knowning that your above traces mean that we are resending a command to the HBA/storage that has a pending abort going on.