All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH 4/8] virtio: check for transmit checksum config error
Date: Fri, 13 Jun 2014 18:06:21 -0700	[thread overview]
Message-ID: <20140614010851.207429467@networkplumber.org> (raw)
In-Reply-To: 20140614010617.902738763@networkplumber.org

[-- Attachment #1: virtio-no-offloads.patch --]
[-- Type: text/plain, Size: 1195 bytes --]

This driver does not support transmit checksum or vlan offload
therefore check for this when device is configured.

Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>

---
 lib/librte_ether/rte_ethdev.h       |    8 +++++---
 lib/librte_pmd_virtio/virtio_rxtx.c |    9 ++++++++-
 2 files changed, 13 insertions(+), 4 deletions(-)

--- a/lib/librte_pmd_virtio/virtio_rxtx.c	2014-06-13 17:55:01.788243375 -0700
+++ b/lib/librte_pmd_virtio/virtio_rxtx.c	2014-06-13 17:59:19.372748301 -0700
@@ -390,13 +390,20 @@ virtio_dev_tx_queue_setup(struct rte_eth
 			uint16_t queue_idx,
 			uint16_t nb_desc,
 			unsigned int socket_id,
-			__rte_unused const struct rte_eth_txconf *tx_conf)
+			const struct rte_eth_txconf *tx_conf)
 {
 	uint8_t vtpci_queue_idx = 2 * queue_idx + VTNET_SQ_TQ_QUEUE_IDX;
 	struct virtqueue *vq;
 	int ret;
 
 	PMD_INIT_FUNC_TRACE();
+
+	if ((tx_conf->txq_flags & ETH_TXQ_FLAGS_NOOFFLOADS)
+	    != ETH_TXQ_FLAGS_NOOFFLOADS) {
+		PMD_INIT_LOG(ERR, "TX checksum offload not supported\n");
+		return -EINVAL;
+	}
+
 	ret = virtio_dev_queue_setup(dev, VTNET_TQ, queue_idx, vtpci_queue_idx,
 			nb_desc, socket_id, &vq);
 	if (ret < 0) {

  parent reply	other threads:[~2014-06-14  1:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-14  1:06 [PATCH 0/8] virtio driver phase 2 Stephen Hemminger
2014-06-14  1:06 ` [PATCH 1/8] virtio: maintain stats per queue Stephen Hemminger
2014-06-14  1:06 ` [PATCH 2/8] virtio: dont double space log messages Stephen Hemminger
2014-06-14  1:06 ` [PATCH 3/8] virtio: deinline some code Stephen Hemminger
2014-06-14  1:06 ` Stephen Hemminger [this message]
2014-06-14  1:06 ` [PATCH 5/8] virtio: check for ip checksum offload Stephen Hemminger
2014-06-14  1:06 ` [PATCH 6/8] virtio: remove unused virtqueue name Stephen Hemminger
2014-06-14  1:06 ` [PATCH 7/8] virtio: remove unused adapter_stopped field Stephen Hemminger
2014-06-14  1:06 ` [PATCH 8/8] virtio: simplify the hardware structure Stephen Hemminger
     [not found] ` <20140614010617.902738763-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-06-17 23:35   ` [PATCH 0/8] virtio driver phase 2 Stephen Hemminger
     [not found]     ` <20140617163541.1debf76e-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-19 10:14       ` Carew, Alan
2014-06-20 13:34   ` Carew, Alan
     [not found]     ` <0E29434AEE0C3A4180987AB476A6F630593A81F5-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-22 13:19       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140614010851.207429467@networkplumber.org \
    --to=stephen-otpzqlsittunbdjkjebofr2eb7je58tq@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.