All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: David Aguilar <davvid@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk: use mktemp -d to avoid predictable temporary directories
Date: Sun, 15 Jun 2014 14:57:52 +1000	[thread overview]
Message-ID: <20140615045752.GF21978@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1402695828-91537-1-git-send-email-davvid@gmail.com>

On Fri, Jun 13, 2014 at 02:43:48PM -0700, David Aguilar wrote:
> gitk uses a predictable ".gitk-tmp.$PID" pattern when generating
> a temporary directory.
> 
> Use "mktemp -d .gitk-tmp.XXXXXX" to harden gitk against someone
> seeding /tmp with files matching the pid pattern.
> 
> Signed-off-by: David Aguilar <davvid@gmail.com>

Thanks, applied.

Paul.

  reply	other threads:[~2014-06-15  4:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 21:43 [PATCH] gitk: use mktemp -d to avoid predictable temporary directories David Aguilar
2014-06-15  4:57 ` Paul Mackerras [this message]
2014-06-15  7:51 ` Pat Thoyts
2014-06-15 16:32   ` brian m. carlson
2014-06-15 21:49     ` David Aguilar
2014-06-15 22:16       ` brian m. carlson
2014-06-16 18:17       ` Junio C Hamano
2014-06-19  2:54         ` David Aguilar
2014-06-16 11:40   ` Thomas Braun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140615045752.GF21978@iris.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.