From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH] netfilter: ctnetlink: fix refcnt leak in dying/unconfirmed list dumper
Date: Mon, 16 Jun 2014 13:12:03 +0200 [thread overview]
Message-ID: <20140616111203.GA25217@localhost> (raw)
In-Reply-To: <1402220483-10565-1-git-send-email-fw@strlen.de>
On Sun, Jun 08, 2014 at 11:41:23AM +0200, Florian Westphal wrote:
> 'last' keeps track of the ct that had its refcnt bumped during previous
> dump cycle. Thus it must not be overwritten until end-of-function.
>
> Another (unrelated, theoretical) issue: Don't attempt to bump refcnt of a conntrack
> whose reference count is already 0. Such conntrack is being destroyed
> right now, its memory is freed once we release the percpu dying spinlock.
>
> Fixes: b7779d06 ('netfilter: conntrack: spinlock per cpu to protect special lists.')
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> With this patch I do not see any more stale entries on the dying list with eache evictor
> not being scheduled. Such 'leaked' entries are easy to spot since their 'use' count
> is growing, i.e. invoking conntrack -L dying repeatedly yields 'use=$bignum++' output.
Applied, thanks Florian!
prev parent reply other threads:[~2014-06-16 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 9:41 [PATCH] netfilter: ctnetlink: fix refcnt leak in dying/unconfirmed list dumper Florian Westphal
2014-06-08 15:57 ` Pablo Neira Ayuso
2014-06-16 11:12 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616111203.GA25217@localhost \
--to=pablo@netfilter.org \
--cc=brouer@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.