All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] xen/grant-table: fix suspend for non-PV guests
Date: Mon, 16 Jun 2014 14:56:56 -0400	[thread overview]
Message-ID: <20140616185656.GA1825@laptop.dumpdata.com> (raw)
In-Reply-To: <1402919358-9564-1-git-send-email-david.vrabel@citrix.com>

On Mon, Jun 16, 2014 at 12:49:18PM +0100, David Vrabel wrote:
> Commit aa8532c32216ae07c3813b9aeb774517878a7573 (xen: refactor suspend
> pre/post hooks) broke resuming PVHVM (auto-translated physmap) guests.
> 
> The gnttab_suspend() would clear the mapping for the grant table
> frames, but the ->unmap_frames() call is only applicable to PV guests.
> 
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>

When I do 'v3.15' + 'stable/for-linus-3.16' merge it fixes the
issue I had seen. You can pluck:

Reported-and-Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thank you.
> ---
>  drivers/xen/grant-table.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> index 6d325bd..5d4de88 100644
> --- a/drivers/xen/grant-table.c
> +++ b/drivers/xen/grant-table.c
> @@ -1168,7 +1168,8 @@ int gnttab_resume(void)
>  
>  int gnttab_suspend(void)
>  {
> -	gnttab_interface->unmap_frames();
> +	if (!xen_feature(XENFEAT_auto_translated_physmap))
> +		gnttab_interface->unmap_frames();
>  	return 0;
>  }
>  
> -- 
> 1.7.10.4
> 

      parent reply	other threads:[~2014-06-16 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 11:49 [PATCH] xen/grant-table: fix suspend for non-PV guests David Vrabel
2014-06-16 14:20 ` Konrad Rzeszutek Wilk
2014-06-16 14:32   ` David Vrabel
2014-06-16 18:56 ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140616185656.GA1825@laptop.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.