From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeremiah Mahler <jmmahler@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] unpack-trees: simplify via strnncmp()
Date: Mon, 16 Jun 2014 13:19:05 -0700 [thread overview]
Message-ID: <20140616201905.GP8557@google.com> (raw)
In-Reply-To: <ee1716e209794a66eb9677e798164a356276700e.1402945507.git.jmmahler@gmail.com>
Jeremiah Mahler wrote:
> --- a/unpack-trees.c
> +++ b/unpack-trees.c
[...]
> @@ -678,7 +667,7 @@ static int find_cache_pos(struct traverse_info *info,
> ce_len = ce_slash - ce_name;
> else
> ce_len = ce_namelen(ce) - pfxlen;
> - cmp = name_compare(p->path, p_len, ce_name, ce_len);
> + cmp = strnncmp(p->path, p_len, ce_name, ce_len);
Likewise --- the sign of the result is important here.
prev parent reply other threads:[~2014-06-16 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 19:13 [PATCH 0/3] add strnncmp() function Jeremiah Mahler
2014-06-16 19:13 ` [PATCH 1/3] " Jeremiah Mahler
2014-06-16 20:16 ` Jonathan Nieder
2014-06-16 19:13 ` [PATCH 2/3] tree-walk: simplify via strnncmp() Jeremiah Mahler
2014-06-16 20:18 ` Jonathan Nieder
2014-06-17 7:13 ` Jeremiah Mahler
2014-06-16 19:13 ` [PATCH 3/3] unpack-trees: " Jeremiah Mahler
2014-06-16 20:19 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616201905.GP8557@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jmmahler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.