From: Sam Ravnborg <sam@ravnborg.org>
To: Borislav Petkov <bp@alien8.de>
Cc: lkml <linux-kernel@vger.kernel.org>, Michael Matz <matz@suse.de>,
linux-kbuild@vger.kernel.org, x86-ml <x86@kernel.org>
Subject: Re: [RFC] Turn off -Wmaybe-uninitialized completely and move it to W=1
Date: Mon, 16 Jun 2014 23:14:05 +0200 [thread overview]
Message-ID: <20140616211405.GA7914@ravnborg.org> (raw)
In-Reply-To: <20140616132045.GE8170@pd.tnic>
On Mon, Jun 16, 2014 at 03:20:45PM +0200, Borislav Petkov wrote:
> Hi,
>
> so 3.16-rc1 adds this false positive from gcc, see below (triggers on
> 4.9 and 4.8.2). Now, it is firing wrong and gcc people tell me there's
> no way for the compiler to know that the "from" and "to" values will NOT
> be used in the error case, i.e. thus the "maybe" aspect.
>
> So, we've disabled it for -Os already:
>
> e74fc973b6e5 ("Turn off -Wmaybe-uninitialized when building with -Os")
>
> maybe we want to disable it by default on all and move it to W=1. This
> way people can still have it fire but not by default. And from what I've
> seen so far, it is mostly firing wrong and it is becoming annoying.
>
> So what do people think, any reasons for keeping it enabled by default?
Agreed.
The noise ratio is too high - so move it to W=1.
Sam
next prev parent reply other threads:[~2014-06-16 21:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 13:20 [RFC] Turn off -Wmaybe-uninitialized completely and move it to W=1 Borislav Petkov
2014-06-16 21:14 ` Sam Ravnborg [this message]
2014-06-24 21:38 ` [PATCH] Kbuild: Move -Wmaybe-uninitialized " Borislav Petkov
2014-07-07 10:53 ` Borislav Petkov
2014-07-08 9:25 ` Paul Bolle
2014-07-08 11:37 ` Borislav Petkov
2014-07-10 10:42 ` Borislav Petkov
2014-07-10 11:03 ` Paul Bolle
2016-07-28 4:20 ` Borislav Petkov
2016-07-28 8:29 ` Ingo Molnar
2016-07-28 8:46 ` Borislav Petkov
2016-07-28 16:49 ` Ingo Molnar
2016-07-28 17:04 ` Ingo Molnar
2016-07-28 17:56 ` Markus Trippelsdorf
2016-07-28 19:03 ` Linus Torvalds
2016-07-28 19:08 ` Linus Torvalds
2016-07-28 20:28 ` Ingo Molnar
2016-07-28 21:22 ` Linus Torvalds
2016-07-29 10:08 ` Arnd Bergmann
2016-07-29 10:19 ` Borislav Petkov
2016-07-29 10:35 ` Arnd Bergmann
2016-07-29 18:26 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616211405.GA7914@ravnborg.org \
--to=sam@ravnborg.org \
--cc=bp@alien8.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matz@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.