From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43195)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WwgDj-0000Iz-66
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 19:21:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WwgDd-0002MK-K4
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 19:21:47 -0400
Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:45587)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WwgDd-0002Lr-Cw
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 19:21:41 -0400
Received: by mail-we0-f170.google.com with SMTP id w61so6512876wes.15
	for <qemu-devel@nongnu.org>; Mon, 16 Jun 2014 16:21:40 -0700 (PDT)
Date: Tue, 17 Jun 2014 01:13:26 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20140616231326.GL3378@toto>
References: <1402326269-8573-1-git-send-email-edgar.iglesias@gmail.com>
	<1402326269-8573-14-git-send-email-edgar.iglesias@gmail.com>
	<CAOgzsHVfpFW6OMmyX75KZw-myFKVLvDezFfqBfDqgsbQac8L9Q@mail.gmail.com>
	<CAFEAcA96xH9HfMZE7q7jtn8a=D2Md20Z+7wmQ7QjqtOEv7RfQA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA96xH9HfMZE7q7jtn8a=D2Md20Z+7wmQ7QjqtOEv7RfQA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 13/17] target-arm: Use uint16_t in
 syndrome generators with 16bit imms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Fabian Aggeler <aggelerf@ethz.ch>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, John Williams <john.williams@xilinx.com>, Greg Bellows <greg.bellows@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On Wed, Jun 11, 2014 at 10:05:35PM +0100, Peter Maydell wrote:
> On 11 June 2014 20:19, Greg Bellows <greg.bellows@linaro.org> wrote:
> > Called out possibly missing fix below.  Beside it, I'm convinced this change
> > is beneficial, other than maybe for readability.
> 
> "not convinced" ?
> 
> Personally, I don't much care either way, but I would suggest that
> if you're trying to get a big fat patchset through it's usually better
> not to throw in too many not-actually-needed patches :-)

Allright, I didn't have this in my v1 but added it in response to review
comments. Will drop it for v3. Agree that we better do this change separately.

Cheers,
Edgar