From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/317,318: fail gracefully if userns not supported
Date: Tue, 17 Jun 2014 12:10:33 +1000 [thread overview]
Message-ID: <20140617021033.GF9508@dastard> (raw)
In-Reply-To: <539B6E3A.4060008@redhat.com>
On Fri, Jun 13, 2014 at 04:33:46PM -0500, Eric Sandeen wrote:
> generic/317 and generic/318 fail un-gracefully on older kernels
> which don't support userns; fix that by running a simple test
> as a prerequisite and fail gracefully if needed.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/tests/generic/317 b/tests/generic/317
> index e016a42..8919db2 100755
> --- a/tests/generic/317
> +++ b/tests/generic/317
> @@ -56,6 +56,8 @@ _supported_os Linux
> [ -x $nsexec ] || _notrun "$nsexec executable not found"
> [ -x $lstat64 ] || _notrun "$lstat64 executable not found"
>
> +$nsexec -U true 2>/dev/null || _notrun "user namespaces not supported by this kernel"
> +
Can you turn this into a _requires_user_namespaces()?
i.e. check for $nsexec and the kernel support in one function.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-06-17 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 21:33 [PATCH] generic/317,318: fail gracefully if userns not supported Eric Sandeen
2014-06-17 2:10 ` Dave Chinner [this message]
2014-06-17 2:44 ` [PATCH V2] " Eric Sandeen
2014-06-17 7:46 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617021033.GF9508@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.