Re: [PATCH v6] libxl: add option for discard support to xl disk configuration

[Olaf Hering <olaf@aepfle.de>]

On Tue, Jun 17, Ian Campbell wrote:

> On Tue, 2014-06-17 at 08:36 +0200, Olaf Hering wrote:
> > +++ b/tools/libxl/libxl.c
> > @@ -2292,6 +2292,9 @@ int libxl__device_disk_setdefault(libxl__gc *gc, libxl_device_disk *disk)
> >  {
> >      int rc;
> >  
> > +    if (!libxl_defbool_is_default(disk->discard_enable))
> > +        libxl_defbool_setdefault(&disk->discard_enable, !!disk->readwrite);
> No need for the condition here, setdefault already incorporates it.
> 
> I think with that changed this is probably the right fix.

I sent an fix: 'libxl: properly set default of discard_enable'.

Olaf