Re: [alsa-devel] [PATCH v3 1/2] ASoC: add es8328 codec driver

[Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>]

On Tue, Jun 17, 2014 at 11:46:39AM +0100, Charles Keepax wrote:
> On Tue, Jun 17, 2014 at 05:32:50PM +0800, Sean Cross wrote:
> > Add a codec driver for the Everest ES8328.  It supports two separate audio
> > outputs and two separate audio inputs.
> > 
> > Signed-off-by: Sean Cross <xobs-nXMMniAx+RbQT0dZR+AlfA@public.gmane.org>
> > ---
> >  Documentation/devicetree/bindings/sound/es8328.txt |  18 +
> >  sound/soc/codecs/Kconfig                           |  13 +
> >  sound/soc/codecs/Makefile                          |   6 +
> >  sound/soc/codecs/es8328-i2c.c                      |  55 ++
> >  sound/soc/codecs/es8328-spi.c                      |  44 ++
> >  sound/soc/codecs/es8328.c                          | 625 +++++++++++++++++++++
> >  sound/soc/codecs/es8328.h                          | 313 +++++++++++
> >  7 files changed, 1074 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/sound/es8328.txt
> >  create mode 100644 sound/soc/codecs/es8328-i2c.c
> >  create mode 100644 sound/soc/codecs/es8328-spi.c
> >  create mode 100644 sound/soc/codecs/es8328.c
> >  create mode 100644 sound/soc/codecs/es8328.h
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/es8328.txt b/Documentation/devicetree/bindings/sound/es8328.txt
> > new file mode 100644
> > index 0000000..488bc32
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/es8328.txt
> > @@ -0,0 +1,18 @@
> > +Everest ES8328 audio CODEC
> > +
> > +This device supports both I2C and SPI (configured with pin strapping
> > +on the board).
> > +
> > +Required properties:
> > +
> > +  - compatible : "es8328"
> 
> I suspect the vendor prefix will be mandatory.

Yes.

There doesn't seem to be a prefix for Everest in vendor-prefixes.txt,
Sean could you please add one as part of this series?

Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html