From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <j-keerthy@ti.com>
Cc: linux-omap@vger.kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, linux-kernel@vger.kernel.org,
sameo@linux.intel.com
Subject: Re: [PATCH 8/9] regulator: palmas: add driver data and modularize the probe
Date: Tue, 17 Jun 2014 17:45:02 +0100 [thread overview]
Message-ID: <20140617164502.GS29841@lee--X1> (raw)
In-Reply-To: <1401272423-25761-9-git-send-email-j-keerthy@ti.com>
> add driver data and modularize the probe.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/mfd/palmas.c | 42 +--
> drivers/regulator/palmas-regulator.c | 656 ++++++++++++++++++++--------------
> 2 files changed, 395 insertions(+), 303 deletions(-)
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
[...]
> @@ -370,6 +334,8 @@ int palmas_ext_control_req_config(struct palmas *palmas,
> int bit_pos;
> int ret;
>
> + struct palmas_pmic_driver_data *pmic_ddata = palmas->pmic_ddata;
> +
Nit: I'd prefer the declarations to be grouped together, normally with
the struct defines above the ints etc.
[...]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-06-17 16:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 10:20 [PATCH 0/9] mfd: tps65917: Add support for for TPS65917 PMIC Keerthy
2014-05-28 10:20 ` Keerthy
2014-05-28 10:20 ` [PATCH 1/9] mfd: Add DT bindings for tps65917 PMIC Keerthy
2014-05-28 10:20 ` Keerthy
2014-05-28 10:20 ` [PATCH 2/9] regulator: palmas: Add tps65917 compatible string Keerthy
2014-05-28 10:20 ` Keerthy
2014-05-28 10:20 ` [PATCH 3/9] mfd: palmas: Add tps65917 specific definitions and enums Keerthy
2014-05-28 10:20 ` Keerthy
2014-06-17 16:11 ` Lee Jones
2014-06-17 16:11 ` Lee Jones
2014-06-18 5:07 ` Keerthy
2014-06-18 5:07 ` Keerthy
2014-05-28 10:20 ` [PATCH 4/9] mfd: palmas: Add tps65917 support Keerthy
2014-05-28 10:20 ` Keerthy
2014-06-17 16:19 ` Lee Jones
2014-06-18 5:06 ` Keerthy
2014-06-18 5:06 ` Keerthy
2014-05-28 10:20 ` [PATCH 5/9] regulator: palmas: Shift the reg_info structure definition to the header file Keerthy
2014-05-28 10:20 ` Keerthy
2014-06-17 16:32 ` Lee Jones
2014-06-18 5:05 ` Keerthy
2014-06-18 5:05 ` Keerthy
2014-05-28 10:20 ` [PATCH 6/9] mfd: palmas: shift the palmas_sleep_requestor_info " Keerthy
2014-05-28 10:20 ` Keerthy
2014-06-17 16:33 ` Lee Jones
2014-06-18 5:04 ` Keerthy
2014-06-18 5:04 ` Keerthy
2014-05-28 10:20 ` [PATCH 7/9] regulator: palmas: Add palmas_pmic_driver_data structure Keerthy
2014-05-28 10:20 ` Keerthy
2014-06-17 16:37 ` Lee Jones
2014-06-18 5:01 ` Keerthy
2014-06-18 5:01 ` Keerthy
2014-06-18 7:24 ` Lee Jones
2014-06-18 7:24 ` Lee Jones
2014-05-28 10:20 ` [PATCH 8/9] regulator: palmas: add driver data and modularize the probe Keerthy
2014-05-28 10:20 ` Keerthy
2014-06-17 16:45 ` Lee Jones [this message]
2014-06-18 4:53 ` Keerthy
2014-06-18 4:53 ` Keerthy
2014-05-28 10:20 ` [PATCH 9/9] regulator: palmas: Add tps65917 PMIC support Keerthy
2014-05-28 10:20 ` Keerthy
2014-06-06 10:59 ` [PATCH 0/9] mfd: tps65917: Add support for for TPS65917 PMIC Keerthy
2014-06-06 10:59 ` Keerthy
2014-06-06 12:43 ` Lee Jones
2014-06-06 12:43 ` Lee Jones
2014-06-06 12:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617164502.GS29841@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.