From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators Date: Tue, 17 Jun 2014 22:17:47 +0100 Message-ID: <20140617211747.GY29841@lee--X1> References: <1402941758-11216-1-git-send-email-javier.martinez@collabora.co.uk> <1402941758-11216-8-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1402941758-11216-8-git-send-email-javier.martinez@collabora.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Javier Martinez Canillas Cc: Alessandro Zummo , Krzysztof Kozlowski , Kukjin Kim , Mike Turquette , Samuel Ortiz , Tomeu Vizoso , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Doug Anderson , linux-samsung-soc@vger.kernel.org, Sjoerd Simons , Mark Brown , Olof Johansson , linux-arm-kernel@lists.infradead.org, Daniel Stone List-Id: linux-samsung-soc@vger.kernel.org PiBUaGUgTUFYNzc4MDIgUE1JQyBoYXMgMTAgaGlnaC1lZmZpY2llbmN5IEJ1Y2sgYW5kIDMyIExv dy1kcm9wb3V0Cj4gKExETykgcmVndWxhdG9ycy4gVGhpcyBwYXRjaCBhZGRzIHN1cHBvcnQgZm9y IGFsbCB0aGVzZSByZWd1bGF0b3JzCj4gZm91bmQgb24gdGhlIE1BWDc3ODAyIFBNSUMgYW5kIGlz IGJhc2VkIG9uIGEgZHJpdmVyIGFkZGVkIGJ5IFNpbW9uCj4gR2xhc3MgdG8gdGhlIENocm9tZSBP UyBrZXJuZWwgMy44IHRyZWUuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmF2aWVyIE1hcnRpbmV6IENh bmlsbGFzIDxqYXZpZXIubWFydGluZXpAY29sbGFib3JhLmNvLnVrPgo+IC0tLQo+IAo+IENoYW5n ZXMgc2luY2UgdjE6Cj4gIC0gUmVtb3ZlIHVubmVlZGVkIGNoZWNrIGlmIG51bV9yZWd1bGF0b3Jz ICE9IE1BWDc3ODAyX01BWF9SRUdVTEFUT1JTLgo+ICAtIEZpeCAuc2V0X3N1c3BlbmRfbW9kZSBo YW5kbGVyIGNvbW1lbnQgYW5kIHNwbGl0IHJlZ3VsYXRvcnMgb3BzIGZvcgo+ICAgIHJlZ3VsYXRv cnMgdGhhdCBiZWhhdmUgZGlmZmVyZW50bHkuIFN1Z2dlc3RlZCBieSBNYXJrIEJyb3duLgo+ICAt IFVzZSBtb2R1bGVfcGxhdGZvcm1fZHJpdmVyKCkgaW5zdGVhZCBvZiBoYXZpbmcgaW5pdC9leGl0 IGZ1bmN0aW9ucy4KPiAgICBTdWdnZXN0ZWQgYnkgTWFyayBCcm93bi4KPiAgLSBVc2UgdGhlIG5l dyBkZXNjcmlwdG9yLWJhc2VkIEdQSU8gaW50ZXJmYWNlIGluc3RlYWQgb2YgdGhlIGRlcHJlY2F0 ZWQKPiAgICBpbnRlZ2VyIGJhc2VkIEdQSU8gb25lLiBTdWdnZXN0ZWQgYnkgTWFyayBCcm93bi4K PiAgLSBMb29rIGZvciAicmVndWxhdG9ycyIgY2hpbGQgbm9kZSBpbnN0ZWFkIG9mICJ2b2x0YWdl LXJlZ3VsYXRvcnMiIHRvIGJlCj4gICAgY29uc2lzdGVudCB3aXRoIG90aGVyIFBNSUMgZHJpdmVy cy4gU3VnZ2VzdGVkIGJ5IE1hcmsgQnJvd24uCj4gCj4gIGRyaXZlcnMvbWZkL21heDc3ODAyLmMg ICAgICAgfCAgIDEgKwoKQ2FuIHlvdSByZW1vdmUgYWxsIG9mIHRoZSBNRkQgY2hhbmdlcyBmcm9t IHBhdGNoZXMgNywgOCBhbmQgOSBhbmQKY3JlYXRlIG5ldyBvbmUuICBUaGF0IHdheSB0aGVyZSdz IG5vIHJlcXVpcmVtZW50IGZvciBhbnkgY3Jvc3MKc3Vic3lzdGVtIG1lc3NpbmVzcy4KCj4gIGRy aXZlcnMvcmVndWxhdG9yL0tjb25maWcgICAgfCAgIDkgKwo+ICBkcml2ZXJzL3JlZ3VsYXRvci9N YWtlZmlsZSAgIHwgICAxICsKPiAgZHJpdmVycy9yZWd1bGF0b3IvbWF4Nzc4MDIuYyB8IDcwMSAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDQgZmlsZXMgY2hh bmdlZCwgNzEyIGluc2VydGlvbnMoKykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvcmVn dWxhdG9yL21heDc3ODAyLmMKCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmlj cyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 17 Jun 2014 22:17:47 +0100 Subject: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators In-Reply-To: <1402941758-11216-8-git-send-email-javier.martinez@collabora.co.uk> References: <1402941758-11216-1-git-send-email-javier.martinez@collabora.co.uk> <1402941758-11216-8-git-send-email-javier.martinez@collabora.co.uk> Message-ID: <20140617211747.GY29841@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout > (LDO) regulators. This patch adds support for all these regulators > found on the MAX77802 PMIC and is based on a driver added by Simon > Glass to the Chrome OS kernel 3.8 tree. > > Signed-off-by: Javier Martinez Canillas > --- > > Changes since v1: > - Remove unneeded check if num_regulators != MAX77802_MAX_REGULATORS. > - Fix .set_suspend_mode handler comment and split regulators ops for > regulators that behave differently. Suggested by Mark Brown. > - Use module_platform_driver() instead of having init/exit functions. > Suggested by Mark Brown. > - Use the new descriptor-based GPIO interface instead of the deprecated > integer based GPIO one. Suggested by Mark Brown. > - Look for "regulators" child node instead of "voltage-regulators" to be > consistent with other PMIC drivers. Suggested by Mark Brown. > > drivers/mfd/max77802.c | 1 + Can you remove all of the MFD changes from patches 7, 8 and 9 and create new one. That way there's no requirement for any cross subsystem messiness. > drivers/regulator/Kconfig | 9 + > drivers/regulator/Makefile | 1 + > drivers/regulator/max77802.c | 701 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 712 insertions(+) > create mode 100644 drivers/regulator/max77802.c -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965383AbaFQVSG (ORCPT ); Tue, 17 Jun 2014 17:18:06 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:39741 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965359AbaFQVSE (ORCPT ); Tue, 17 Jun 2014 17:18:04 -0400 Date: Tue, 17 Jun 2014 22:17:47 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: Samuel Ortiz , Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Sjoerd Simons , Daniel Stone , Tomeu Vizoso , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators Message-ID: <20140617211747.GY29841@lee--X1> References: <1402941758-11216-1-git-send-email-javier.martinez@collabora.co.uk> <1402941758-11216-8-git-send-email-javier.martinez@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1402941758-11216-8-git-send-email-javier.martinez@collabora.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout > (LDO) regulators. This patch adds support for all these regulators > found on the MAX77802 PMIC and is based on a driver added by Simon > Glass to the Chrome OS kernel 3.8 tree. > > Signed-off-by: Javier Martinez Canillas > --- > > Changes since v1: > - Remove unneeded check if num_regulators != MAX77802_MAX_REGULATORS. > - Fix .set_suspend_mode handler comment and split regulators ops for > regulators that behave differently. Suggested by Mark Brown. > - Use module_platform_driver() instead of having init/exit functions. > Suggested by Mark Brown. > - Use the new descriptor-based GPIO interface instead of the deprecated > integer based GPIO one. Suggested by Mark Brown. > - Look for "regulators" child node instead of "voltage-regulators" to be > consistent with other PMIC drivers. Suggested by Mark Brown. > > drivers/mfd/max77802.c | 1 + Can you remove all of the MFD changes from patches 7, 8 and 9 and create new one. That way there's no requirement for any cross subsystem messiness. > drivers/regulator/Kconfig | 9 + > drivers/regulator/Makefile | 1 + > drivers/regulator/max77802.c | 701 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 712 insertions(+) > create mode 100644 drivers/regulator/max77802.c -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog