All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: relative objtree change broke tar builds?
Date: Tue, 17 Jun 2014 18:38:54 -0400	[thread overview]
Message-ID: <20140617223854.GC6168@fieldses.org> (raw)

The scripts I use for my kernel testing rely on the targz-pkg make
target.  After updating to 3.16-rc1 my scripts started failing.  In
scripts/package/buildtar:

  tmpdir="${objtree}/tar-install"
  tarball="${objtree}/linux-${KERNELRELEASE}-${ARCH}.tar"
..
  #
  # Create the tarball
  #
  (
        cd "${tmpdir}"
        opts=
        if tar --owner=root --group=root --help >/dev/null 2>&1; then
                opts="--owner=root --group=root"
        fi
        tar cf - boot/* lib/* $opts | ${compress} > "${tarball}${file_ext}"
  )


After 7e1c04779efd511 "kbuild: Use relative path for $(objtree)", that's a
relative instead of absolute path so the tarball's dumped by default into
tmpdir, not what was intended.

The changelog there says

	The main Makefile sets its working directory to the object tree
	and never changes it again. Therefore, we can use '.' instead of
	the absolute path.

But the main Makefile also exports objtree, and a quick grep suggests
lots of other uses outside the main Makefile.

--b.

             reply	other threads:[~2014-06-17 22:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 22:38 J. Bruce Fields [this message]
2014-06-18  9:06 ` relative objtree change broke tar builds? Michal Marek
2014-06-18 12:20   ` J. Bruce Fields
2014-06-18 12:33     ` Michal Marek
2014-06-18 13:14       ` J. Bruce Fields
2014-06-18 15:58         ` Randy Dunlap
2014-06-18 19:47           ` Michal Marek
2014-06-18 19:52             ` Sam Ravnborg
2014-06-18 21:13               ` Randy Dunlap
2014-07-04 21:37                 ` Michal Marek
2014-07-04 21:40                   ` Randy Dunlap
2014-07-07  1:04                   ` Randy Dunlap
2014-06-18 21:20             ` Randy Dunlap
2014-06-19  1:21             ` Ken Moffat
2014-07-04 21:42               ` Michal Marek
2014-06-18 14:26 ` [PATCH] kbuild: Fix tar-pkg with relative $(objtree) Michal Marek
2014-06-18 15:29   ` J. Bruce Fields
2014-06-18 15:34     ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140617223854.GC6168@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.