From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] NVMe: Fail SCSI->NVMe translation for UNMAP when anchor is set
Date: Wed, 18 Jun 2014 11:45:32 -0400 [thread overview]
Message-ID: <20140618154532.GI12025@linux.intel.com> (raw)
In-Reply-To: <alpine.WNT.2.00.1406180929430.12984@DMCLERAN-DESK.amr.corp.intel.com>
On Wed, Jun 18, 2014@09:30:24AM -0600, Dan McLeran wrote:
> Good point. So, is Anchor == 1 still illegal for non-resource-provisioned
> devices? The spec seems to imply that must be the case.
The current revision of the spec seems contradictory. On the one hand,
it says that ANC_SUP shall be set to 0. SBC says you're not allowed to
set the ANCHOR bit if ANC_SUP is 0. And then the NVMe-SCSI spec says that
you can set ANCHOR if the underlying namespace is "resource provisioned"
which isn't something that actually exists in NVMe.
Since there's no way to actually pass the ANCHOR bit through, and we
always set ANC_SUP to 0, I think we should go with your original patch,
failing the command if ANCHOR is set.
next prev parent reply other threads:[~2014-06-18 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 9:03 [PATCH] NVMe: Fail SCSI->NVMe translation for UNMAP when anchor is set Dan McLeran
2014-06-18 15:13 ` Keith Busch
2014-06-18 15:15 ` Dan McLeran
2014-06-18 15:27 ` Matthew Wilcox
2014-06-18 15:30 ` Dan McLeran
2014-06-18 15:45 ` Matthew Wilcox [this message]
2014-06-18 15:51 ` Mayes, Barrett N
2014-06-18 16:04 ` Keith Busch
2014-06-18 16:25 ` Matthew Wilcox
2014-06-18 17:23 ` Mayes, Barrett N
2014-06-18 15:35 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618154532.GI12025@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.