From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Miller Subject: Re: [PATCH 2/2] Add embedded nul string list test Date: Wed, 18 Jun 2014 12:35:19 -0500 Message-ID: <20140618173519.GA15740@toadite.austin.ibm.com> References: <1402936552-10249-1-git-send-email-jack@codezen.org> <1402936552-10249-3-git-send-email-jack@codezen.org> <20140618012729.GE29264@voom.redhat.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=xuW+Rn6awOg/5YJF1mbiA42EUfxJyZ3MG1kE4lJLVqg=; b=itJ5cMeBTMHGIUfJ/0MwpqTfhfVprANo1KkcZgP0WkM0feV8NllTCd75AEwH2kRPOD I3Ad1scHlOIyR3VDnB+ia8wHw0ITmOvWlBB3eWOGcH/NkYNaTK9SM88R4NKc4l2L15TI E1Awm4wtyp/pcRWTyiQ0GkGMiEPPZOgqo8JVkXS9zts2r1Kp9vIJEgjWQsk7cZ57DEbO tJab878UcjveglqfbCjp/TLr5rY0+bztzEprXbOZsy416PhOFXprcMyEt4FJyYMFerDY cNoHcHaXSOemAsK0SOgQJueQDtraJ7LxCrQDgW/YRn+ZmRf01aJjFhMeW4AJYad5rC7H QNPw== Content-Disposition: inline In-Reply-To: <20140618012729.GE29264-1s0os16eZneny3qCrzbmXA@public.gmane.org> Sender: devicetree-compiler-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Gibson Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, Jun 18, 2014 at 11:27:29AM +1000, David Gibson wrote: > > @@ -310,6 +310,9 @@ dtc_tests () { > > run_dtc_test -I dts -O dtb -o dtc_comments-cmp.test.dtb comments-cmp.dts > > run_test dtbs_equal_ordered dtc_comments.test.dtb dtc_comments-cmp.test.dtb > > > > + run_dtc_test -I dts -O dtb -o dtc_nul_string_list.dtb nul_string_list.dts > > dtb files generated by the tests should be named XXX.test.dtb so that > make clean will clean them up again. Hmmm, the greater problem here seems to be that I'm including a .dtb that *isn't* disposable and will be cleaned. Should this test check that the generated dtb decompiles into "","","" format instead of comparing to a binary? That seems a little weak as it assumes that the intermediate .dtb is correct, but I don't know your thoughts on including binaries into your test directory. - Jack -- To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html