All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chase Southwood <chase.southwood@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: comedi: addi_apci_1564: remove send_sig() use
Date: Wed, 18 Jun 2014 15:07:52 -0700	[thread overview]
Message-ID: <20140618220752.GA26985@kroah.com> (raw)
In-Reply-To: <1401424913-21859-1-git-send-email-chase.southwood@gmail.com>

On Thu, May 29, 2014 at 11:41:53PM -0500, Chase Southwood wrote:
> The addi-data drivers use send_sig() to let the user know when an
> interrupt has occurred. The "standard" way to do this in the comedi
> subsystem is to have a subdevice that supports asynchronous commands
> and use comedi_event() to signal the user.
> 
> Remove the send_sig() usage in this driver.
> 
> Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> ---
>  .../comedi/drivers/addi-data/hwdrv_apci1564.c      | 23 ----------------------
>  1 file changed, 23 deletions(-)

This doesn't apply to my tree :(

Can you refresh this series based on the review comments for the later
patches and please resend?

thanks,

greg k-h

  parent reply	other threads:[~2014-06-18 22:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30  4:40 [PATCH 0/6] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality Chase Southwood
2014-05-30  4:41 ` [PATCH 1/6] staging: comedi: addi_apci_1564: remove send_sig() use Chase Southwood
2014-05-30 16:37   ` Hartley Sweeten
2014-06-18 22:07   ` Greg KH [this message]
2014-05-30  4:42 ` [PATCH 2/6] staging: comedi: addi_apci_1564: remove use of devpriv->b_OutputMemoryStatus Chase Southwood
2014-05-30 16:38   ` Hartley Sweeten
2014-05-30  4:42 ` [PATCH 3/6] staging: comedi: addi_apci_1564: introduce apci1564_private struct Chase Southwood
2014-05-30 16:44   ` Hartley Sweeten
2014-05-30  4:43 ` [PATCH 4/6] staging: comedi: addi_apci_1564: add a subdevice for Change-of-State interrupt support Chase Southwood
2014-05-30 16:49   ` Hartley Sweeten
2014-05-30  4:43 ` [PATCH 5/6] staging: comedi: addi_apci_1564: hook-up the interrupt subdevice Chase Southwood
2014-05-30 16:57   ` Hartley Sweeten
2014-05-30  4:43 ` [PATCH 6/6] staging: comedi: addi_apci_1564: cleanup v_ADDI_Interrupt() Chase Southwood
2014-05-30 17:26   ` Hartley Sweeten
2014-06-02  3:52     ` Chase Southwood
2014-05-30  7:45 ` [PATCH 0/6] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140618220752.GA26985@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=chase.southwood@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.