All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chase Southwood <chase.southwood@gmail.com>
Cc: devel@driverdev.osuosl.org, abbotti@mev.co.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] staging: comedi: addi_apci_1564: remove use of devpriv->b_OutputMemoryStatus
Date: Wed, 18 Jun 2014 15:09:47 -0700	[thread overview]
Message-ID: <20140618220947.GA27255@kroah.com> (raw)
In-Reply-To: <1401849217-21562-1-git-send-email-chase.southwood@gmail.com>

On Tue, Jun 03, 2014 at 09:33:37PM -0500, Chase Southwood wrote:
> This member of the private data struct is only set at one location in the
> entire driver, and then never even used for anything.  Let's just remove
> its use.
> 
> Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
> Cc: H Hartley Sweeeten <hsweeten@visionengravers.com>
> ---
>  drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5 -----
>  1 file changed, 5 deletions(-)

Ah, you did redo the series.  But this one still doesn't apply :(

Care to try again?

thanks,

greg k-h

  reply	other threads:[~2014-06-18 22:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  2:32 [PATCH v2 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality Chase Southwood
2014-06-04  2:33 ` [PATCH v2 1/5] staging: comedi: addi_apci_1564: remove use of devpriv->b_OutputMemoryStatus Chase Southwood
2014-06-18 22:09   ` Greg KH [this message]
2014-06-04  2:34 ` [PATCH v2 2/5] staging: comedi: addi_apci_1564: remove unused static variables Chase Southwood
2014-06-04  2:34 ` [PATCH v2 3/5] staging: comedi: addi_apci_1564: introduce apci1564_private struct Chase Southwood
2014-06-04  2:34 ` [PATCH v2 4/5] staging: comedi: addi_apci_1564: add Change-of-State interrupt subdevice and required functions Chase Southwood
2014-06-04  2:35 ` [PATCH v2 5/5] staging: comedi: addi_apci_1564: move apci1564_interrupt() into addi_apci_1564.c Chase Southwood
2014-06-05 13:22 ` [PATCH v2 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140618220947.GA27255@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=chase.southwood@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.