All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Adithya Krishnamurthy <linux.challenge1@gmail.com>
Cc: omar.ramirez@copitl.com, rashika.kheria@gmail.com,
	freemangordon@abv.bg, dan.carpenter@oracle.com,
	ody.guru@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] Staging:tidspbridge Fix minor checkpatch.pl warning.
Date: Wed, 18 Jun 2014 15:24:57 -0700	[thread overview]
Message-ID: <20140618222457.GA2317@kroah.com> (raw)
In-Reply-To: <53942534.9010701@gmail.com>

On Sun, Jun 08, 2014 at 02:26:20PM +0530, Adithya Krishnamurthy wrote:
> From: Adithya Krishnamurthy <linux.challenge1@gmail.com>
> 
> Fixed checkpatch "WARNING: Missing a blank line after declarations"
> 
> Signed-off-by: Adithya Krishnamurthy <linux.challenge1@gmail.com>
> ---
>  drivers/staging/tidspbridge/core/chnl_sm.c       |    1 +
>  drivers/staging/tidspbridge/core/io_sm.c         |    1 +
>  drivers/staging/tidspbridge/core/tiomap3430.c    |    2 ++
>  drivers/staging/tidspbridge/core/tiomap_io.c     |    2 ++
>  drivers/staging/tidspbridge/core/wdt.c           |    1 +
>  drivers/staging/tidspbridge/dynload/cload.c      |    7 +++++++
>  drivers/staging/tidspbridge/dynload/reloc.c      |    2 ++
>  drivers/staging/tidspbridge/pmgr/chnl.c          |    1 +
>  drivers/staging/tidspbridge/rmgr/dbdcd.c         |    1 +
>  drivers/staging/tidspbridge/rmgr/drv_interface.c |    2 ++
>  drivers/staging/tidspbridge/rmgr/nldr.c          |    1 +
>  drivers/staging/tidspbridge/rmgr/node.c          |    2 ++
>  drivers/staging/tidspbridge/rmgr/proc.c          |    3 +++
>  13 files changed, 26 insertions(+)
> 
> diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c
> index 16fa346..c855992 100644
> --- a/drivers/staging/tidspbridge/core/chnl_sm.c
> +++ b/drivers/staging/tidspbridge/core/chnl_sm.c
> @@ -486,6 +486,7 @@ int bridge_chnl_get_info(struct chnl_object *chnl_obj,
>  {
>  	int status = 0;
>  	struct chnl_object *pchnl = (struct chnl_object *)chnl_obj;
> +
>  	if (channel_info != NULL) {
>  		if (pchnl) {
>  			/* Return the requested information: */


Your email client put an extra space in front of every line, making this
patch not able to be applied :(

Care to fix that up and resend?

thanks,

greg k-h

      reply	other threads:[~2014-06-18 22:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 14:58 [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warning Adithya.K
2014-06-04 15:10 ` Greg KH
2014-06-08  8:56 ` [PATCH V2] " Adithya Krishnamurthy
2014-06-18 22:24   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140618222457.GA2317@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=freemangordon@abv.bg \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.challenge1@gmail.com \
    --cc=ody.guru@gmail.com \
    --cc=omar.ramirez@copitl.com \
    --cc=rashika.kheria@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.